#108237
ea7dd8ebb249e
-
Split out side-effects from viewmode plugin to seperate plugin to reduce cyclical dependency risk
WHAT
- Remove
createFilterStepsPlugin
from the editorViewMode Plugin and is implemented in
editorViewModeEffects instead.
- Remove
appendTransaction
from the editorViewMode plugin and add as a new PMPlugin in
editorViewModeEffects
applyViewModeStepAt
is moved to editorViewModeEffects. This is currently only used in
Annotation plugin which now consumes the new plugin instead and has a minor bump.
WHY
ViewMode information is needed for upstream work in the CollabEdit plugin (see ED-23466).
Currently the viewMode plugin already depends on CollabEdit and as such implementing new work
causes a cylical dependency problem. ViewMode is likely to be required in an increasing number of
plugins and ideally should be as pure as possible with no dependencies. A larger rethink of how
these plugins fit together may be required but that is outside the scope of this change.
HOW
All incompatibilities should be addressed within this changeset, however for the sake of
completeness:
editor-plugin-editor-viewmode-effects
must be added to any preset that relies on the viewmode
filter steps plugin for viewmode annotations. Currently this seems to only be the confluence
editor itself.
applyViewModeStepAt
should now be called from the editorViewModeEffects
plugin. This will
need to be added to your plugin types independently (all uses covered by this change)