A comment displays discussions and user feedback.
yarn add @atlaskit/comment#117363
10a0f7f6c2027 -
This package's peerDependencies have been adjusted for react and/or react-dom to reflect the
status of only supporting React 18 going forward. No explicit breaking change to React support has
been made in this release, but this is to signify going forward, breaking changes for React 16 or
React 17 may come via non-major semver releases.
Please refer this community post for more details: https://community.developer.atlassian.com/t/rfc-78-dropping-support-for-react-16-and-rendering-in-a-react-18-concurrent-root-in-jira-and-confluence/87026
b50c5d5d65ae2 -
Bump to the latest version of @compiled/react4660ec858a305 -
Update React from v16 to v187b1a8574e9c29 -
Fix or temporarily ignore TypeScript errors that occur in internal React 18 suites.2bacf5973e142 -
Fix missing comment text styles on @atlaskit/comment from incorrect Compiled style exraction.5ee4ec31e3c07 -
Fixes incorrect usage of cssMap where it was being passed directly into a css prop instead of
passing the nested default variant.519dd18d0d28c -
Migrated from @emotion/react to @compiled/react in order to improve performance, align with
therest of the Atlaskit techstack, and support React 18 Streaming SSR.Please note, in order to use
thisversion of @atlaskit/comment, you will need to ensure that your bundler is configured to
handle.css imports correctly.Most bundlers come with built-in support for .css imports, so you
may notneed to do anything. If you are using a different bundler, please refer to the
documentation forthat bundler to understand how to handle .css imports.For more information on
the migration,please refer to [RFC-73 Migrating our
components
toCompiledCSS-in-JS](https://community.developer.atlassian.com/t/rfc-73-migrating-our-components-to-compiled-css-in-js/85957f451bda8919 -
Adds side-effect config to support Compiled css extraction in third-party appsa0a6a008a0dba -
Internal feature flag changes to support icon migratione5394ab79e19e -
Removes internal exports which are not exported via the main entrypoint0358a3e6378d2 -
Refactors analytics next API to remove usages of legacy react context.80b5875f4290c -
Migrate comment to use new typography system internally.#127511
db30e29344013 -
Widening range of react and react-dom peer dependencies from ^16.8.0 || ^17.0.0 || ~18.2.0
to the wider range of ``^16.8.0 || ^17.0.0 || ^18.0.0` (where applicable).
This change has been done to enable usage of react@18.3 as well as to have a consistent peer
dependency range for react and react-dom for /platform packages.
cd506a937e44f -
Internal change to how typography is applied. There should be no visual change.ff0815316ab38 -
Removes usage of custom theme button in places where its API is not being used and the default
button is able to be used instead. This should give a slight performance (runtime) improvement.223959ef57c80 -
Explicitly set jsxRuntime to classic via pragma comments in order to avoid issues where jsxRuntime
is implicitly set to automatic.3fa98157d575 -
Internal changes to update dependencies. There is no expected visual change.77ad8ff5584f -
Fix text auto-collapse behaviour for commenteade79144064 -
Internal change to use @atlaskit/primitives Text component.bb63ac6494f7 -
Fix @atlaskit/comment to properly order grid template areas when children aren't present
following @atlaskit/primitives specificity change.2c82f078edae -
Internal change to improve how styles are applied. There is no expected visual difference.6900f89eb0e - Internal
changes to use space tokens. There is no expected visual or behaviour change.cf6302f0150 -
Accessibility changes. The default header has a h3 tag. Heading level can be changed using the
headingLevel prop.4ae083a7e66 - Use
@af/accessibility-testing for default jest-axe config and jest-axe import in accessibility
testing.7e4085cd951 - Allow
caret version range in @atlaskit/primitives dependency.529814693a1 - Pin
version of @atlaskit/primitives so it resolves to correct version779727e307a - Internal
change only. Replace all instances of Box with stable @atlaskit/primitives version.56507598609 - Skip
minor dependency bump2e01c9c74b5 - DUMMY
remove before merging to master; dupe adf-schema via adf-utils261420360ec - Upgrades
component types to support React 18.b6c5779d358 - Internal
changes only to restrict usage of Box from the primitives package.6d665548890 - Update
usages of Inline and Stack to make use of stable version in @atlaskit/primitives. Internal
change only.18aeca8c199 - Internal
change to update token references. There is no expected behaviour or visual change.eadbf13d8c0 - Updated
usages of Text, Box, Stack, and Inline primitives to reflect their updated APIs. There are
no visual or behaviour changes.b0f6dd0bc35 - Updated
to use typography tokens. There is no expected behaviour or visual change.#26801
749a2ff3ddf - [ux]
Visual changes to adjust the gutter whitespace between nested comments. This change is to better
match the white space of other components in the Atlassian Design System. There is a second more
subtle visual fix for comments that have no nesting. This was a regression introduced in v10.1.
Additionally, the heading role is now applied specifically on the author of the comment, rather than all nodes.
Other internal changes:
bc989043572 - Internal
changes to apply spacing tokens. This should be a no-op change.60b1a234357 - Updates
@emotion/core to @emotion/react; v10 to v11. There is no expected behavior change.7252fae2582 - Fixed an
issue where shouldRenderNestedCommentsInline was not working30603005cbd - [ux]
Migrated deprecated design tokens to recommended replacementsf460cc7c411 - Builds
for this package now pass through a tokens babel plugin, removing runtime invocations of the
tokens() function and improving bundle size.9721e13533b - Comment
now exposes testId which can be used to aid automated testing.2b98dfda0a6 - Removes
@emotion/styled in favour of @emotion/core.8aa7c4e9ff9 - Update
example in order to fix internal test.a92e5a614ce - Comment
is now instrumented with the new tokens theme implementation.f6b951a51f2 - Removes
usage of styled-components in favour of standardising on emotion79c23df6340 - Use
injected package name and version for analytics instead of version.json.5f58283e1f - Export
types using Typescript's new "export type" syntax to satisfy Typescript's --isolatedModules
compiler option. This requires version 3.8 of Typescript, read more about how we handle Typescript
versions here: https://atlaskit.atlassian.com/get-started Also add typescript to
devDependencies to denote version that the package was built with.2ac834240e - Undo
analytics-next file restructure to allow external ts definitions to continue working#3885
6c525a8229 - Upgraded
to TypeScript 3.9.6 and tslib to 2.0.0
Since tslib is a dependency for all our packages we recommend that products also follow this tslib upgrade to prevent duplicates of tslib being bundled.
87f4720f27 - Officially
dropping IE11 support, from this version onwards there are no warranties of the package working in
IE11. For more information see:
https://community.developer.atlassian.com/t/atlaskit-to-drop-support-for-internet-explorer-11-from-1st-july-2020/3953454a9514fcf - Build and
supporting files will no longer be published to npmbaaad91b65 - Updated to
use the latest and more performant version of @atlaskit/avatar[patch]6f36add6ae:
Change imports to comply with Atlassian conventions- Updated dependencies 7e4d4a7ed4:
Updated dependencies 999fbf849e:
Updated dependencies b202858f6c:
Updated dependencies 9cee2b03e8:
Updated dependencies 26de083801:
Updated dependencies d3cc97a424:
Updated dependencies 00f64f4eb8:
Updated dependencies 4f70380793:
Updated dependencies 6b8e60827e:
Updated dependencies 449ef134b3:
Updated dependencies 5b301bcdf6:
Updated dependencies 729a4e4960:
Updated dependencies 167a55fd7a:
Updated dependencies 57c0487a02:
Updated dependencies c8d0ce5b94:
Updated dependencies 384791fb2b:
Updated dependencies a4d063330a:
Updated dependencies c6b145978b:
Updated dependencies 736507f8e0:
Updated dependencies cf41823165:
Updated dependencies 9e3646b59e:
Updated dependencies aec7fbadcc:
Updated dependencies e477132440:
[minor]6289157cf2:
Ability to render conversation comments inline rather than nested using optional
AkConversation.maxCommentNesting prop.
[patch]6548261c9a:
Remove namespace imports from React, ReactDom, and PropTypes- Updated dependencies 6548261c9a:
[patch]4a223473c5:
Removes babel/runtime from dependencies. Users should see a smaller bundlesize as a result- Updated dependencies 28f8f0e089:
Updated dependencies 6042417190:
Updated dependencies 26942487d1:
Updated dependencies 8db35852ab:
Updated dependencies 2ffdeb5a48:
Updated dependencies 9219b332cb:
Updated dependencies 82747f2922:
Updated dependencies 99fc6250f9:
Updated dependencies 46e6693eb3:
Updated dependencies 4cd37dd052:
Updated dependencies 1f84cf7583:
Updated dependencies 218fe01736:
Updated dependencies 985db883ac:
Updated dependencies bed9c11960:
Updated dependencies a30fe6c66e:
Updated dependencies fdf30da2db:
Updated dependencies d1c470507c:
Updated dependencies fc1678c70d:
Updated dependencies 2edd170a68:
Updated dependencies e5dd37f7a4:
Updated dependencies 5abcab3f7e:
Updated dependencies 5d13d33a60:
Updated dependencies 1d421446bc:
Updated dependencies 4a223473c5:
[minor]0c383bebaa:
Adds optional renderAfterComment prop to Conversation to allow consumers to render something
after a comment but before its nested comments
[minor]0afd21589d:
Add optional renderAdditionalCommentActions prop to Conversation component. Add optional
isDisabled prop to CommentAction component.
[patch]35d2229b2a:
Adding missing license to packages and update to Copyright 2019 Atlassian Pty Ltd.
[major]2376ada634:
Comment has been converted to Typescript. Typescript consumers will now get static type safety. Flow types are no longer provided. No API or behavioural changes.
[patch]a2d0043716:
Updated version of analytics-next to fix potential incompatibilities with TS 3.6
[patch]097b696613:
Components now depend on TS 3.6 internally, in order to fix an issue with TS resolving non-relative imports as relative imports
[patch]708028db86:
Change all the imports to theme in Core to use multi entry points
[patch]9f8ab1084b:
Consume analytics-next ts type definitions as an ambient declaration.
[major]7c17b35107:
[major]76299208e6:
As a breaking change, all @atlaskit packages will be dropping cjs distributions and will only
distribute esm. This means all distributed code will be transpiled, but will still contain
import and export declarations.
The major reason for doing this is to allow us to support multiple entry points in packages, e.g:
import colors from `@atlaskit/theme/colors`;
Previously this was sort of possible for consumers by doing something like:
import colors from `@atlaskit/theme/dist/esm/colors`;
This has a couple of issues. 1, it treats the file system as API making internal refactors harder, we have to worry about how consumers might be using things that aren't actually supposed to be used. 2. We are unable to do this internally in @atlaskit packages. This leads to lots of packages bundling all of theme, just to use a single color, especially in situations where tree shaking fails.
To support being able to use multiple entrypoints internally, we unfortunately cannot have multiple distributions as they would need to have very different imports from of their own internal dependencies.
ES Modules are widely supported by all modern bundlers and can be worked around in node environments.
We may choose to revisit this solution in the future if we find any unintended condequences, but we see this as a pretty sane path forward which should lead to some major bundle size decreases, saner API's and simpler package architecture.
Please reach out to #fabric-build (if in Atlassian) or create an issue in Design System Support (for external) if you have any questions or queries about this.
[patch]19783cb: